fix: web types #8401
Merged
fix: web types #8401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
commented
Oct 22, 2025
There was a problem hiding this comment.
two small things:
yarn.lock changes after installing deps on you branch
also, when i run web-example i get:
Web Bundling failed 118ms apps/web-example/index.js (1 module)
ERROR index.js: Package subpath './babel' is not defined by "exports" in /Users/marcysia/swm/repos/react-native-reanimated/node_modules/react-strict-dom/package.json
apps/common-app/src/apps/css/examples/animations/screens/realWorldExamples/Emojis.tsx
Show resolved
Hide resolved
Are you sure? Everything is okay on my end. Moreover, if yarn.lock were stale it would've been picked up on CI. Have you tested the latest commit on the PR? |
patrycjakalinska
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for
Summary
This PR is an ongoing effort to reduce the impact of Reanimated and Worklets in web bundles and to simplify the logic of platform-dependent code.
The ideal solution is to have native-only files with a
.native.tsextension and web only files with just.tsextension alongside them. However, currently we also have.web.tsfiles, which can be problematic in some environments. We want to transition to.native.tsfiles gradually.This PR does a few things:
It edits TSConfigs alongside the repository. By default we specify that accepted extensions are
.native.ts,.ios.ts,.android.ts,.ts(obviously also.tsxetc.). This means that when in IDE we clickgo to sourcewe'll go to a.nativefile which is the most common use case for us. Also types for type-checking will be pulled like this.We add additional TSConfigs for web types. These extensions ignore
.native.etc. extensions and accept.webextensions. You can switch to those TSConfigs for web type-checking in your IDE.Adding type checking scripts and CI checks for web types.
Fixing (or ignoring) all current problems with web types - i.e. mismatching web and native types in Reanimated.
Amending eslint configs to properly work in this setup.
Test plan
CI